HtmlHelper::getCrumbs() - semantically correct output
Reported by shazarre | June 25th, 2010 @ 04:24 AM | in 2.0.0 (closed)
First, read the discussion please:
http://groups.google.com/group/cake-php/browse_thread/thread/9c36d2...
As said there, I can contribute and fix it. That's my first ticket, so I'm a bit confused... Am I to attach a diff?
Comments and changes to this ticket
-
shazarre June 25th, 2010 @ 04:28 AM
- no changes were found...
-
-
ADmad June 25th, 2010 @ 01:16 PM
- → Milestone set to “RFC”
- → Tag changed from “accessibility, htmlhelper” to “getcrumbs, htmlhelper, rfc”
Links to other locations for better understanding of the issue are welcome, but next time please try to include at least the basic info in the ticket itself :) You can attach a diff for you changes or better yet fork the cakephp project on github make changes there and post a link to relevant commit here.
-
shazarre June 27th, 2010 @ 11:09 AM
Ok, thanks for you reply and advice ;) Here is a link to the commit:
http://github.com/shazarre/cakephp/commit/2e134e8d2b2c9adf0365b4e66... -
Mark Story June 27th, 2010 @ 11:57 AM
- → Tag changed from “getcrumbs, htmlhelper, rfc” to “enhancement, getcrumbs, htmlhelper”
- → Assigned user set to “Mark Story”
- → Milestone changed from “RFC” to “2.0.0”
Moving to 2.0 as this seems like a reasonable change. Thanks for the patch and test case :)
-
CakePHP June 28th, 2010 @ 09:37 PM
- → State changed from “new” to “resolved”
(from [68a9c9c5aba2bcbc4a2ce34856d0425c0364b5df]) Added HtmlHelper::getCrumbList() to generate semantically correct (x)html breadcrumb navigation path and a test to it. Fixes #856
Signed-off-by: mark_story mark@mark-story.com
http://github.com/cakephp/cakephp/commit/68a9c9c5aba2bcbc4a2ce34856...
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
Repository is at http://github.com/cakephp/cakephp
Creating a bug report
When creating a bug report, please include as much relevant information as possible. Please include code to reproduce the issue. Or even better, make a unit test. Either change an existing test or add a new test to show that the expected behavior is not occuring.
People watching this ticket
Referenced by
-
#856 HtmlHelper::getCrumbs() - semantically correct output
(from [68a9c9c5aba2bcbc4a2ce34856d0425c0364b5df])
Added H...